This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" #54250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
This reverts commit 59351b4.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jul 31, 2024
auto-submit
bot
deleted the
revert_59351b437de7f701c79e040ce8e54567cd0761bf
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2024
…152625) flutter/engine@b73367a...3b31b21 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (#54240)" (flutter/engine#54250) 2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248) 2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246) 2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245) 2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244) 2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241) 2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Jul 31, 2024
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location. Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details. This is a reland of flutter#54240 which was reverted in flutter#54250 The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy. Issue: flutter/flutter#107884
8 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Jul 31, 2024
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location. Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details. This is a reland of flutter#54240 which was reverted in flutter#54250 The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy. Issue: flutter/flutter#107884
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Jul 31, 2024
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location. Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details. This is a reland of flutter#54240 which was reverted in flutter#54250 The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy. Issue: flutter/flutter#107884
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Our executables are no longer built with bitcode enabled and thus `bitcode_strip -r SOURCE -o DEST` is just copying the file in question to the output location. Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details. This is a reland of #54240 which was reverted in #54250. The the previous version was reverted because Python's `shutil.copyfile` doesn't set the unix permissions of the source file on the destination file. However, when overwriting an existing destination file, it preserves any permissions on that file. One can imagine how this might be problematic if you test the script by running before and after the change with the same output directory. `shutil.copy2` attempts to preserve source file metadata when writing the copy. Issue: flutter/flutter#107884 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152625) flutter/engine@b73367a...3b31b21 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (flutter#54240)" (flutter/engine#54250) 2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248) 2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246) 2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245) 2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244) 2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241) 2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152625) flutter/engine@b73367a...3b31b21 2024-07-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS][macOS] Eliminate use of bitcode_strip (flutter#54240)" (flutter/engine#54250) 2024-07-31 [email protected] Roll Skia from fa9ecbb258b1 to 999e3f113dbf (1 revision) (flutter/engine#54248) 2024-07-31 [email protected] Roll Dart SDK from f10a21fcc61c to edace067d950 (1 revision) (flutter/engine#54246) 2024-07-31 [email protected] Roll Skia from cb6ea5bd807d to fa9ecbb258b1 (3 revisions) (flutter/engine#54245) 2024-07-31 [email protected] Roll Dart SDK from 68e559110999 to f10a21fcc61c (2 revisions) (flutter/engine#54244) 2024-07-31 [email protected] Roll Skia from 26eb1876de72 to cb6ea5bd807d (2 revisions) (flutter/engine#54241) 2024-07-31 [email protected] Roll Skia from b6036baeebbd to 26eb1876de72 (1 revision) (flutter/engine#54239) 2024-07-31 [email protected] [iOS][macOS] Eliminate use of bitcode_strip (flutter/engine#54240) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #54240
Initiated by: zanderso
Reason for reverting: Looks like some issue with file permissions https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20plugin_test_macos/19179/overview
Original PR Author: cbracken
Reviewed By: {zanderso}
This change reverts the following previous change:
Our executables are no longer built with bitcode enabled and thus
bitcode_strip -r SOURCE -o DESTis just copying the file in question to the output location.Use of Bitcode was eliminated in Flutter in 2022. See linked issue for details.
Issue: flutter/flutter#107884
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.